Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(messaging, android): fix native documentation #12968

Merged
merged 1 commit into from
Jun 17, 2024
Merged

chore(messaging, android): fix native documentation #12968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 1 addition & 34 deletions ...ava/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingBackgroundExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,22 +99,6 @@ public void onMethodCall(MethodCall call, @NonNull Result result) {
/**
* Starts running a background Dart isolate within a new {@link FlutterEngine} using a previously
* used entrypoint.
*
* <p>The isolate is configured as follows:
*
* <ul>
* <li>Bundle Path: {@code io.flutter.view.FlutterMain.findAppBundlePath(context)}.
* <li>Entrypoint: The Dart method used the last time this plugin was initialized in the
* foreground.
* <li>Run args: none.
* </ul>
*
* <p>Preconditions:
*
* <ul>
* <li>The given callback must correspond to a registered Dart callback. If the handle does not
* resolve to a Dart callback then this method does nothing.
* </ul>
*/
public void startBackgroundIsolate() {
if (isNotRunning()) {
Expand All @@ -125,24 +109,7 @@ public void startBackgroundIsolate() {
}
}

/**
* Starts running a background Dart isolate within a new {@link FlutterEngine}.
*
* <p>The isolate is configured as follows:
*
* <ul>
* <li>Bundle Path: {@code io.flutter.view.FlutterMain.findAppBundlePath(context)}.
* <li>Entrypoint: The Dart method represented by {@code callbackHandle}.
* <li>Run args: none.
* </ul>
*
* <p>Preconditions:
*
* <ul>
* <li>The given {@code callbackHandle} must correspond to a registered Dart callback. If the
* handle does not resolve to a Dart callback then this method does nothing.
* </ul>
*/
/** Starts running a background Dart isolate within a new {@link FlutterEngine}. */
public void startBackgroundIsolate(long callbackHandle, FlutterShellArgs shellArgs) {
if (backgroundFlutterEngine != null) {
Log.e(TAG, "Background isolate already started.");
Expand Down
Loading