Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gRPC 1.66.0 #14342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update to gRPC 1.66.0 #14342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseFirestoreInternal.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ Google Cloud Firestore is a NoSQL document database built for automatic scaling,
s.dependency 'abseil/time', abseil_version
s.dependency 'abseil/types', abseil_version

s.dependency 'gRPC-Core', '~> 1.65.0'
s.dependency 'gRPC-C++', '~> 1.65.0'
s.dependency 'gRPC-Core', '~> 1.66.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're updating, why not get fully up to date with the latest 1.69

s.dependency 'gRPC-C++', '~> 1.66.0'
s.dependency 'leveldb-library', '~> 1.22'
s.dependency 'nanopb', '~> 3.30910.0'

Expand Down
1 change: 1 addition & 0 deletions Firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased
- [fixed] Fixed use-after-free bug when internally formatting strings. (#14306)
- [changed] Update gRPC dependency to 1.66.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as fixing #14323?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on the fence about this. I personally haven't been able to verify that this fixes #14323 given that the issue is not deterministically reproducible. Based on the stack trace and @HannahShiSFB's comment, it's very likely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My perception is that the only reasonable next step for #14323 is asking a customer to validate if 1.66.0 addresses it, so we should do so and then reinvestigate if it doesn't fix it.


# 11.6.0
- [fixed] Add conditional `Sendable` conformance so `ServerTimestamp<T>` is
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,7 @@ func grpcDependency() -> Package.Dependency {
// If building Firestore from source, abseil will need to be built as source
// as the headers in the binary version of abseil are unusable.
if ProcessInfo.processInfo.environment["FIREBASE_SOURCE_FIRESTORE"] != nil {
packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.65.0" ..< "1.66.0")
packageInfo = ("https://github.com/grpc/grpc-ios.git", "1.66.0" ..< "1.67.0")
} else {
packageInfo = ("https://github.com/google/grpc-binary.git", "1.65.1" ..< "1.66.0")
}
Expand Down
Loading