Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): reduce config spread #216

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

TobiTenno
Copy link
Collaborator

@TobiTenno TobiTenno commented Feb 19, 2021

combine configs
move ci to github actions (faster, more reliable, less limited)

@filipedeschamps if this all works, I'll need you to add an npm token to the repository secrets as NPM_TOKEN, as well as to change the expected checks from coveralls and travis over to the new ones from the github actions

@TobiTenno
Copy link
Collaborator Author

@filipedeschamps could you remove travis and add the lint and test actions as required instead?

@TobiTenno
Copy link
Collaborator Author

and we need a token added to the repo as NPM_TOKEN for publishing automatically with gh actions?

@TobiTenno TobiTenno force-pushed the ci/config-reduction branch from f4439dc to 9b6d4c4 Compare May 12, 2021 00:13
@TobiTenno TobiTenno requested a review from filipedeschamps June 9, 2021 04:07
@TobiTenno TobiTenno force-pushed the ci/config-reduction branch 4 times, most recently from e81ab07 to 1ba25f0 Compare February 13, 2022 00:28
@filipedeschamps
Copy link
Owner

  1. Removed all required checks.
  2. Added NPM_TOKEN secret.
  3. I will now close and reopen the PR.

@filipedeschamps
Copy link
Owner

Added the remaining checks:

image

@TobiTenno
Copy link
Collaborator Author

thanks! I'll get this one fixed up and merged whenever i get the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants