Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add workflow to generate documentation on PR merge #12681

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(docs): add workflow to generate documentation on PR merge #12681

wants to merge 5 commits into from

Conversation

virajbhartiya
Copy link
Member

@virajbhartiya virajbhartiya commented Nov 7, 2024 •
edited
Loading

Related Issues

Closes #12233

Proposed Changes

Add a workflow that run make docsgen-cli whenever the PR is merged

Checklist

rvagg
rvagg reviewed Nov 7, 2024
View reviewed changes
.github/workflows/check.yml Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Nov 7, 2024

@virajbhartiya can you resolve the conflict with master here please? You'll see that your " substitutions are getting in the way, so resolving those would be good.

@virajbhartiya
Copy link
Member Author

Hey @rvagg, I have resolved the conflicts in the PR

@virajbhartiya
Copy link
Member Author

@rvagg any suggestions on why is the workflow failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvagg rvagg rvagg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: 🔎 Awaiting review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run make docsgen-cli on merge
2 participants
@virajbhartiya @rvagg