Merge pull request #142 from fhir-crucible/get-when-flag-false

Add test to make sure that GETs are issued when search flag is false

.github/workflows/ruby.yml

@@ -0,0 +1,26 @@
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.6', '2.7']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake
+    - name: Rubocop
+      run: bundle exec rubocop

Rakefile

@@ -19,7 +19,7 @@ task :rubocop do
   RuboCop::RakeTask.new
 end
 
-task test: [:rubocop] do
+task :test do
   system('open coverage/index.html')
 end
 

lib/fhir_client/sections/search.rb

@@ -12,7 +12,7 @@ def search(klass, options = {}, format = @default_format)
         options[:resource] = klass
         options[:format] = format
 
-        reply = if options.dig(:search, :flag).nil? && options.dig(:search, :body).nil?
+        reply = if options.dig(:search, :flag) != true && options.dig(:search, :body).nil?
                   get resource_url(options), fhir_headers
                 else
                   options[:search][:flag] = true

lib/fhir_client/version.rb

@@ -1,5 +1,5 @@
 module FHIR
   class Client
-    VERSION = '4.0.5'.freeze
+    VERSION = '4.0.6'.freeze
   end
 end

test/unit/client_interface_sections/search_test.rb

@@ -47,6 +47,26 @@ def test_get_search
     )
     assert_requested(search_response)
   end
+
+  def test_get_search_flag_false
+    search_response = stub_request(:get, 'http://search-test/Patient?address=123%20Sesame%20Street&given=name').
+      to_return(empty_search_response)
+
+    reply = @client.search(
+      FHIR::Patient,
+      {
+        search: {
+          flag: false,
+          parameters: {
+            given: 'name',
+            address: '123 Sesame Street'
+          }
+        }
+      }
+    )
+    assert_requested(search_response)
+  end
+
   def test_post_search
     search_body = {
             given: 'name',