-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for high contrast mode #377
base: master
Are you sure you want to change the base?
Conversation
Note that the SVG currently doesn't render properly in Firefox with a strict CSP due to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1262842.
Changes to make spinner visible in high contrast mode
Changes for high contrast mode
@fgnass @theodorejb Please review this PR |
@pratikgolchha Have you tested this? The property value needs to be a string. Also, the transparent border seems to cause an issue where setting line length to |
Added high contrast css
@theodorejb I have removed the border and applied it only in high contrast mode. |
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast has the following warning:
Also, were you able to get it working? For me the style applied when not in the media query, but when in the media query it didn't apply even when high contrast mode was active (tested in IE 11 and Edge 18). |
ed37b95
to
ae42fa6
Compare
Changes for high contrast mode. Spinner is not visible in high contrast mode