Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for high contrast mode #377

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pratikgolchha
Copy link

Changes for high contrast mode. Spinner is not visible in high contrast mode

@pratikgolchha
Copy link
Author

@fgnass @theodorejb Please review this PR

@theodorejb
Copy link
Collaborator

@pratikgolchha Have you tested this? The property value needs to be a string. Also, the transparent border seems to cause an issue where setting line length to 0 and corners to 1 no longer results in perfectly round circles.

@pratikgolchha
Copy link
Author

@theodorejb I have removed the border and applied it only in high contrast mode.

@theodorejb
Copy link
Collaborator

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast has the following warning:

This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user.

Also, were you able to get it working? For me the style applied when not in the media query, but when in the media query it didn't apply even when high contrast mode was active (tested in IE 11 and Edge 18).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants