feat(core): Introducing uagents-core #597
Conversation
libs/core/uagents_core/logger.py
Outdated
There was a problem hiding this comment.
I guess this is only used in utils, so maybe should be moved there?
There was a problem hiding this comment.
I wanted to introduce unified logging and log style to be adopted in the future.
|
|
||
|
|
||
| class VerifiableModel(BaseModel): | ||
| agent_address: str |
There was a problem hiding this comment.
This will likely need an update very soon based on this PR: #603.
There was a problem hiding this comment.
Since there is a lot of copied/moved code it is actually quite hard to identify what you've changed or added. Also there is no description added to the PR so I can't really understand the reasoning for adding this library.
What is the main benefit for this structure compared to importing what you need for a project directly from uagents?
|
|
||
|
|
||
| [tool.poetry.group.dev.dependencies] | ||
| black = "^24.10.0" |
There was a problem hiding this comment.
black is not used in this project and the lib right now does not have any tests so please remove all unneeded packages if this is meant to have its own pyproject file.
| @@ -1,5 +1,5 @@ | |||
| # The default code owners of the uagents repo. | |||
| * @jrriehl @Archento @lrahmani | |||
| * @jrriehl @Archento @lrahmani @qati | |||
There was a problem hiding this comment.
| * @jrriehl @Archento @lrahmani @qati | |
| * @jrriehl @Archento @lrahmani | |
| /libs/core/ @qati |
I propose this scope as your PR only targets changes in this directory.
Proposed Changes
[describe the changes here...]
Linked Issues
[if applicable, add links to issues resolved by this PR]
Types of changes
What type of change does this pull request make (put an
xin the boxes that apply)?Checklist
Put an
xin the boxes that apply:If applicable
python/scripts/generate_api_docs.py)Further comments
[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]