refactor: CDS logs #383
Merged
refactor: CDS logs #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbukva
reviewed
Oct 3, 2024
pbukva
reviewed
Oct 3, 2024
pbukva
reviewed
Oct 3, 2024
pbukva
reviewed
Oct 4, 2024
app/upgrade_v_11_4_network_config.go
Outdated
| @@ -265,6 +268,7 @@ var NetworkInfos = map[string]NetworkConfig{ | |||
| } | |||
|
|
|||
| type NetworkConfig struct { | |||
| ChainID string `json:"chain_id"` | |||
There was a problem hiding this comment.
Suggested change
| ChainID string `json:"chain_id"` | |
| MergeSourceChainID string `json:"merge_source_chain_id"` | |
| DestinationChainID string `json:"destination_chain_id"```` |
pbukva
reviewed
Oct 4, 2024
pbukva
reviewed
Oct 4, 2024
pbukva
reviewed
Oct 4, 2024
app/app.go
Outdated
Comment on lines
741
to
743
| if networkInfo.ChainID != ctx.ChainID() { | ||
| return nil, fmt.Errorf("source file chain id %s and current node chain id %s is different", networkInfo.ChainID, ctx.ChainID()) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if networkInfo.ChainID != ctx.ChainID() { | |
| return nil, fmt.Errorf("source file chain id %s and current node chain id %s is different", networkInfo.ChainID, ctx.ChainID()) | |
| } | |
| if networkInfo.MergeSourceChainID != mergeSourceGenesisDoc.ChainID { | |
| return nil, fmt.Errorf("source file chain id %s and current node chain id %s is different", networkInfo.MergeSourceChainID, mergeSourceGenesisDoc.ChainID) | |
| } | |
| if networkInfo.DestinationChainID != ctx.ChainID() { | |
| return nil, fmt.Errorf("source file chain id %s and current node chain id %s is different", networkInfo.DestinationChainID, ctx.ChainID()) | |
| } |
See my previous post .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
[describe the changes here...]
Linked Issues
[if applicable, add links to issues resolved by this PR]
Types of changes
What type of change does this pull request make (put an
xin the boxes that apply)?Checklist
Put an
xin the boxes that apply:If applicable
Further comments
[if this is a relatively large or complex change, kick off a discussion by explaining why you chose the solution you did, what alternatives you considered, etc...]