Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psmap implementation in fermipy #578

Merged
merged 23 commits into from
Apr 2, 2024
Merged

Psmap implementation in fermipy #578

merged 23 commits into from
Apr 2, 2024

Conversation

omodei
Copy link
Member

@omodei omodei commented Mar 26, 2024

This PR implements the psmap implementation in fermipy (wrapping the code gtpsmap.py from FSSC (author Philippe Bruel). In particular:

  1. The class PSMapGenerator is implemented as mixing class for GTAnalysis. It provides the method psmap that wrap the code gtpsmap and return the usual dictionary with relevant outputs
  2. AnalysisPlotter.make_psmap_plots provides the same interface of make_tsmap_plots or make_residmap_plots to plot pamaps.
  3. Added relevant documentation in the "Advanced Analysis Methods" tab, with class description and example.
  4. This PR also fix the broken API documentation
  5. This PR fix the random NaN error raised by spicy while scanning the parameters, when the first value of the array is 0

@omodei omodei requested a review from ndilalla March 26, 2024 23:39
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 81.12360% with 84 lines in your changes are missing coverage. Please review.

Project coverage is 49.29%. Comparing base (bc2aa7d) to head (947b6d6).
Report is 5 commits behind head on master.

Files Patch % Lines
fermipy/gtpsmap.py 77.16% 79 Missing ⚠️
fermipy/psmap.py 93.33% 3 Missing ⚠️
fermipy/plotting.py 97.36% 1 Missing ⚠️
fermipy/utils.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   48.73%   49.29%   +0.55%     
==========================================
  Files         141      143       +2     
  Lines       26520    26959     +439     
==========================================
+ Hits        12925    13289     +364     
- Misses      13595    13670      +75     
Flag Coverage Δ
unittests 49.29% <81.12%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omodei omodei mentioned this pull request Apr 1, 2024
Copy link
Contributor

@ndilalla ndilalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@ndilalla ndilalla merged commit c442fe3 into master Apr 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants