Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: keep Host header intact #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Sep 28, 2022

It appears that the original Go code does not change the "Host" header value, so this removes setting the header value to that of the proxied request.

I came across this because a proxy app is setting the forward_url to an IP address while the app being proxied to relies on a FQDN in the Host header for further redirects

@chesedo
Copy link
Contributor Author

chesedo commented Sep 28, 2022

Nvm, just saw the x-forward-host PR which seems like a better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant