Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(firebase_flutter_login): upgrade deps #4224

Merged
merged 1 commit into from
Aug 15, 2024
Merged

chore(firebase_flutter_login): upgrade deps #4224

merged 1 commit into from
Aug 15, 2024

Conversation

LukasMirbt
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

I needed to make the following changes to run the example on iOS on the Flutter stable channel:

  • Upgrade iOS minimum version to 13
  • Remove OTHER_LDFLAGS
  • Upgrade firebase major versions

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel approved these changes Aug 15, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@felangel felangel merged commit 72e928e into felangel:master Aug 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasMirbt @felangel