fix(flutter_login): fix flickering on login transition (#4210)

Co-authored-by: Felix Angelov <[email protected]>
felangel · Jul 26, 2024 · 59d7512 · 59d7512
1 parent 9f393a7
commit 59d7512
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/examples/flutter_login/lib/login/view/login_form.dart b/examples/flutter_login/lib/login/view/login_form.dart
@@ -79,11 +79,11 @@ class _PasswordInput extends StatelessWidget {
 class _LoginButton extends StatelessWidget {
   @override
   Widget build(BuildContext context) {
-    final isInProgress = context.select(
-      (LoginBloc bloc) => bloc.state.status.isInProgress,
+    final isInProgressOrSuccess = context.select(
+      (LoginBloc bloc) => bloc.state.status.isInProgressOrSuccess,
     );
 
-    if (isInProgress) return const CircularProgressIndicator();
+    if (isInProgressOrSuccess) return const CircularProgressIndicator();
 
     final isValid = context.select((LoginBloc bloc) => bloc.state.isValid);
 

diff --git a/examples/flutter_login/test/login/view/login_form_test.dart b/examples/flutter_login/test/login/view/login_form_test.dart
@@ -103,6 +103,25 @@ void main() {
       expect(find.byType(CircularProgressIndicator), findsOneWidget);
     });
 
+    testWidgets('loading indicator is shown when status is submission success',
+        (tester) async {
+      when(() => loginBloc.state).thenReturn(
+        const LoginState(status: FormzSubmissionStatus.success),
+      );
+      await tester.pumpWidget(
+        MaterialApp(
+          home: Scaffold(
+            body: BlocProvider.value(
+              value: loginBloc,
+              child: LoginForm(),
+            ),
+          ),
+        ),
+      );
+      expect(find.byType(ElevatedButton), findsNothing);
+      expect(find.byType(CircularProgressIndicator), findsOneWidget);
+    });
+
     testWidgets('continue button is enabled when status is validated',
         (tester) async {
       when(() => loginBloc.state).thenReturn(const LoginState(isValid: true));