fix(flutter_todos): use ListView.builder for improved performance (#…

…4275) Co-authored-by: Felix Angelov <[email protected]>
felangel · Nov 16, 2024 · 5726a19 · 5726a19
1 parent 5d80dcc
commit 5726a19
Showing 1 changed file with 26 additions and 25 deletions.
diff --git a/examples/flutter_todos/lib/todos_overview/view/todos_overview_page.dart b/examples/flutter_todos/lib/todos_overview/view/todos_overview_page.dart
@@ -100,31 +100,32 @@ class TodosOverviewView extends StatelessWidget {
             }
 
             return CupertinoScrollbar(
-              child: ListView(
-                children: [
-                  for (final todo in state.filteredTodos)
-                    TodoListTile(
-                      todo: todo,
-                      onToggleCompleted: (isCompleted) {
-                        context.read<TodosOverviewBloc>().add(
-                              TodosOverviewTodoCompletionToggled(
-                                todo: todo,
-                                isCompleted: isCompleted,
-                              ),
-                            );
-                      },
-                      onDismissed: (_) {
-                        context
-                            .read<TodosOverviewBloc>()
-                            .add(TodosOverviewTodoDeleted(todo));
-                      },
-                      onTap: () {
-                        Navigator.of(context).push(
-                          EditTodoPage.route(initialTodo: todo),
-                        );
-                      },
-                    ),
-                ],
+              child: ListView.builder(
+                itemCount: state.filteredTodos.length,
+                itemBuilder: (_, index) {
+                  final todo = state.filteredTodos.elementAt(index);
+                  return TodoListTile(
+                    todo: todo,
+                    onToggleCompleted: (isCompleted) {
+                      context.read<TodosOverviewBloc>().add(
+                            TodosOverviewTodoCompletionToggled(
+                              todo: todo,
+                              isCompleted: isCompleted,
+                            ),
+                          );
+                    },
+                    onDismissed: (_) {
+                      context
+                          .read<TodosOverviewBloc>()
+                          .add(TodosOverviewTodoDeleted(todo));
+                    },
+                    onTap: () {
+                      Navigator.of(context).push(
+                        EditTodoPage.route(initialTodo: todo),
+                      );
+                    },
+                  );
+                },
               ),
             );
           },