-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolbox.adoc #117
base: master
Are you sure you want to change the base?
Update toolbox.adoc #117
Conversation
Give a better description of the export of the drag and lift forces (I hope it will be sharper...)
drag and lift are misnamed, they would require having the direction of the flow and the direction of motion. |
correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to remove the notion of drag and lift but add a TIP saying that the forces correspond to the drag and lift of the fluid or object motion is aligned with the x-axis ?
@@ -567,13 +567,18 @@ The user must define: | |||
|
|||
|
|||
==== Forces | |||
compute lift and drag | |||
Compute lift and drag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drag and lift are misnamed, they would require having the direction of the flow and the direction of motion. Forces computes the surfacic forces (F_x, F_y) applied by the fluid to the object. It would be drag and lift if the flow or motion is aligned with the x-axis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentchabannes probably a discussion on forces should be done in http://docs.feelpp.org/toolboxes/0.108/cfd/theory/
|
||
- time | ||
- drag_marker1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think drag and lift should be removed here until we provide a direction of flow or motion
Stale pull request message |
@thomas-saigre could we finish this? |
I do not remember what I was trying to explain here... I think it was about exports for practical work during M1 year, but it's been a while since I last used cfd toolbox... |
Stale pull request message |
Give a better description of the export of the drag and lift forces (I hope it will be sharper...)