Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves : 160 separate plots config from benchmark #204

Merged
merged 13 commits into from
Dec 20, 2024

Conversation

JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Dec 18, 2024

Done:

  • Separated option parsing from main script
  • Renamed render-benchmarks options
  • Added options to patch plot configurations
  • Added a --website flag to automatically compile antora docs and start http server. (quicker than npm run antora && nom run start)

How patching works...
Users can now provide a --plot-configs option with one or more paths to a modified plot configuration file ( to replace in existing reports).
Along with this option, users can (optionally) pass a --patch-reports option (list) containing the "IDs" of the reports to modify. The syntax is machine:application:usecase:date . The date format should be %Y_%m_%dT%H_%M_%S. However, the application, use case and date components can be replaced by all, and the date component can be replaced by latest. If the--save-patches` flag is passed, the content of the old plot configuration files will be replaced by the new ones.

Multiple combinations are possible.

  • If the --plot-configs option is passed alone, with a single filepath: The plots of the latest report are patched.
  • If the --plot-configs is passed along with --patch-reports:
    • If the length of the report id list is the same as the new plot configs, then report's plots will be patched respectively (zipped).
    • If a single plot-config is passed along with an arbitrary number of patch-reports. All passed reports will be replaced with this new plot configuration

@JavierCladellas JavierCladellas linked an issue Dec 18, 2024 that may be closed by this pull request
@JavierCladellas JavierCladellas self-assigned this Dec 18, 2024
@JavierCladellas JavierCladellas added the i/o Issues related to input/output handling label Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit 160673e
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/6765303cf051c90008561bae
😎 Deploy Preview https://deploy-preview-204--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas added the enhancement A new feature or request label Dec 18, 2024
@JavierCladellas JavierCladellas marked this pull request as ready for review December 19, 2024 08:49
@JavierCladellas JavierCladellas merged commit 0887ee2 into master Dec 20, 2024
10 checks passed
@JavierCladellas JavierCladellas deleted the 160-separate-plots-config-from-benchmark branch December 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or request i/o Issues related to input/output handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate plots-config from benchmark
2 participants