Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves: 117 discoverer #182

Merged
merged 60 commits into from
Dec 13, 2024
Merged

resolves: 117 discoverer #182

merged 60 commits into from
Dec 13, 2024

Conversation

JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Dec 6, 2024

Done:

  • Added ReFrame config for discoverer
  • Added shell scripts for gaya and discoverer for runners to launch execute-benchmark
  • Improved the HpcSystem dispatcher
  • Added a dry run option to verify job scripts that will be submitted
  • Updated the thermal_bridges case config
  • Updated the benchmark.yml workflow

@JavierCladellas JavierCladellas linked an issue Dec 6, 2024 that may be closed by this pull request
@JavierCladellas JavierCladellas self-assigned this Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit d3f4733
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/6758738f6cd37c00083450bb
😎 Deploy Preview https://deploy-preview-182--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas added enhancement A new feature or request hpc High-performance computing related ci-cd Continuous Integration/Continuous Deployment cb Continuous Benchmarking labels Dec 6, 2024
@JavierCladellas JavierCladellas marked this pull request as draft December 6, 2024 09:38
@JavierCladellas JavierCladellas marked this pull request as ready for review December 6, 2024 12:28
'prepare_cmds': [
'source /etc/profile.d/modules.sh',
'export MODULEPATH=/opt/software/modulefiles',
'export OMP_NUM_THREADS=1' # Just in case
Copy link
Member

@vincentchabannes vincentchabannes Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be appear here, it's the application which can define this variables (OMP_NUM_THREADS)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a benchmark/application configuration field like

"env_variables":{ "OMP_NUM_THREADS":1 }

that will export environment variables at the start of the benchmark?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator Author

@JavierCladellas JavierCladellas Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the env_variables field under the application config root.
For containers, they should be passed using their native option under the options field. e.g for apptainer:

 "options": [
   "--env OMP_NUM_THREADS=1"
]

I'll let you resolve the conversation if you're OK with this.

@vincentchabannes vincentchabannes merged commit 6df3d44 into master Dec 13, 2024
10 checks passed
@vincentchabannes vincentchabannes deleted the 117-discoverer branch December 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cb Continuous Benchmarking ci-cd Continuous Integration/Continuous Deployment enhancement A new feature or request hpc High-performance computing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dry-run option Discoverer
2 participants