-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves: 117 discoverer #182
Conversation
(module loading is not working tho)
✅ Deploy Preview for benchmarking-polite-crostata-92f389 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/feelpp/benchmarking/reframe/config/machineConfigs/discoverer.py
Outdated
Show resolved
Hide resolved
'prepare_cmds': [ | ||
'source /etc/profile.d/modules.sh', | ||
'export MODULEPATH=/opt/software/modulefiles', | ||
'export OMP_NUM_THREADS=1' # Just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should not be appear here, it's the application which can define this variables (OMP_NUM_THREADS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a benchmark/application configuration field like
"env_variables":{ "OMP_NUM_THREADS":1 }
that will export environment variables at the start of the benchmark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the env_variables
field under the application config root.
For containers, they should be passed using their native option under the options
field. e.g for apptainer:
"options": [
"--env OMP_NUM_THREADS=1"
]
I'll let you resolve the conversation if you're OK with this.
They should be passed under options (--env)
Done:
execute-benchmark