ifup-routes: print warning when ADDRESS0 entry is missing #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When static routes are added via route-<interface> file, the ifup-routes script will skip adding routes if entries not starting with ADDRESS0. Good to print a warning so that users are aware of this.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -14,6 +14,13 @@ | |||
| handle_file () { | |||
| . $1 | |||
| routenum=0 | |||
|
|
|||
| # print a warning if ADDRESS is not starting at ADDRESS0 | |||
| if [ "x$(eval echo '$'ADDRESS$routenum)x" == "xx" ]; then | |||
Check warning
Code scanning / shellcheck
Avoid x-prefix in comparisons as it no longer serves a purpose. Warning
lnykryn
reviewed
Feb 7, 2024
| @@ -14,6 +14,13 @@ MATCH='^[[:space:]]*(\#.*)?$' | |||
| handle_file () { | |||
| . $1 | |||
| routenum=0 | |||
|
|
|||
| # print a warning if ADDRESS is not starting at ADDRESS0 | |||
| if [ "x$(eval echo '$'ADDRESS$routenum)x" == "xx" ]; then | |||
There was a problem hiding this comment.
Looks, fine but two small nitpicks for the future. Since the routenum is always 0, the whole eval shenanigan is unnecessary. Simple [ -z "$ADDRESS0" ] would be much nicer.
lnykryn
reviewed
Feb 7, 2024
| # print a warning if ADDRESS is not starting at ADDRESS0 | ||
| if [ "x$(eval echo '$'ADDRESS$routenum)x" == "xx" ]; then | ||
| net_log $"Route entries are not sequentially ordered. Skipping $1 file" warning | ||
| exit 1 |
There was a problem hiding this comment.
THis can potentially change the behaviour.
|
Hi all, Thanks for the review and for accepting the patch. regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When static routes are added via route- file, the ifup-routes script will skip adding routes if entries not starting with ADDRESS0.
Good to print a warning so that users are aware of this.