This repository has been archived by the owner on Nov 8, 2019. It is now read-only.
Redesign mysql image to work in OpenShift as well #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are based on the code that from https://github.com/openshift/mysql. Even if the image is meant to work in OpenShift, it doesn't mean that it shouldn't work outside of OpenShift -- the opposite is true, the image should be usable on Atomic or normal Fedora Server/Workstation/Cloud without any issues as well.
This was referenced May 26, 2016
|
@misli, may I ask for review of the changes, please? |
|
@misli, ping |
|
@hhorak Hi, can you review your changes? They have been made a while back and they explicitly refer to an EOL version of Fedora. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reworked version of #193.
These changes are based on the code that from https://github.com/openshift/mysql.
Even if the image is meant to work in OpenShift, it doesn't mean that it shouldn't
work outside of OpenShift -- the opposite is true, the image should be usable on
Atomic or normal Fedora Server/Workstation/Cloud without any issues as well.