fix: evaluate variables overridden from rules with no variations #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the bug
When matching both the Traffic (rule equivalent in generated datafiles) and their Allocation, it used to always check if an Allocation is found or not in the Traffic itself.
This was problematic because not all features have variations.
Resulting into issues when evaluating variables (in features with no variations) which have overrides from rule level, because SDK never found any allocation info for them (since they had no variations).
What was done to solve it
When matching both Traffic and Allocation, it will return:
Traffic if segments matched (irrespective of Allocation bucket range checks), and
Allocation if bucket range checks are satisfied