feat: Handle semver comparisons #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykPiwowarczyk
changed the title
P-Jag
approved these changes
Oct 6, 2023
polok
reviewed
Oct 6, 2023
| @@ -1,6 +1,51 @@ | |||
| import FeaturevisorTypes | |||
| import Foundation | |||
|
|
|||
| struct Semver: Equatable { | |||
There was a problem hiding this comment.
Please, move to separate file
polok
reviewed
Oct 6, 2023
| XCTAssertTrue(conditionIsMatched(condition: condition, context: context)) | ||
| } | ||
|
|
||
| func testSemverEquality() { |
There was a problem hiding this comment.
Please move Semver tests into separate file
polok
reviewed
Oct 6, 2023
| XCTAssertTrue(conditionIsMatched(condition: condition, context: context)) | ||
| } | ||
|
|
||
| func testBooleanNotEquals() { |
There was a problem hiding this comment.
Follow the same pattern that we have in other tests. Point out sections like GIVEN, WHEN, THEN
polok
reviewed
Oct 6, 2023
| import FeaturevisorTypes | ||
| import Foundation | ||
|
|
||
| struct Semver: Equatable { |
There was a problem hiding this comment.
Just Semver.swift, not Conditions+Semver.swift
polok
reviewed
Oct 9, 2023
| @@ -21,7 +21,8 @@ extension FeaturevisorInstance { | |||
|
|
|||
| try? fetchDatafileContent( | |||
| from: datafileUrl, | |||
| handleDatafileFetch: handleDatafileFetch) { [weak self] result in | |||
| handleDatafileFetch: handleDatafileFetch | |||
There was a problem hiding this comment.
Please, double check that these format changes follow the current swift-format config
There was a problem hiding this comment.
Updated the branch from the main, both swiftformating and linting shows no errors
polok
approved these changes
Oct 9, 2023
polok
reviewed
Oct 9, 2023
| @@ -0,0 +1,89 @@ | |||
| import XCTest | |||
|
|
|||
| @testable import FeaturevisorSDK | |||
There was a problem hiding this comment.
Last thing. This should be called SemverTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.