chore: fix lint issues. (#50)

featurevisor · Oct 6, 2023 · e80f380 · e80f380
1 parent f037035
commit e80f380
Show file tree

Hide file tree

Showing 8 changed files with 134 additions and 116 deletions.
diff --git a/Sources/FeaturevisorSDK/Bucket.swift b/Sources/FeaturevisorSDK/Bucket.swift
@@ -4,15 +4,16 @@ import MurmurHash_Swift
 
 internal enum Bucket {
 
-    private static let HASH_SEED: UInt32 = 1
-    private static let MAX_HASH_VALUE: Double = pow(2, 32)  // 2^32
-    private static let MAX_BUCKETED_NUMBER = 100000  // 100% * 1000 to include three decimal places in the same integer value
+    private static let hashSeed: UInt32 = 1
+    private static let maxHashValue: Double = pow(2, 32)  // 2^32
+    private static let maxSegmentNumber = 100000
+    // 100% * 1000 to include three decimal places in the same integer value
 
     static func resolveNumber(forKey bucketKey: BucketKey) -> Int {
 
-        let hashValue = MurmurHash3.x86_32.digest(bucketKey, seed: HASH_SEED)
-        let ratio = Double(hashValue) / MAX_HASH_VALUE
+        let hashValue = MurmurHash3.x86_32.digest(bucketKey, seed: hashSeed)
+        let ratio = Double(hashValue) / maxHashValue
 
-        return Int(floor(ratio * Double(MAX_BUCKETED_NUMBER)))
+        return Int(floor(ratio * Double(maxSegmentNumber)))
     }
 }
diff --git a/Sources/FeaturevisorSDK/Conditions.swift b/Sources/FeaturevisorSDK/Conditions.swift
@@ -21,7 +21,7 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
 
     switch (valueInAttributes, valueInCondition) {
         // boolean, boolean
-        case let (.boolean(valueInAttributes), .boolean(valueInCondition)):
+        case (.boolean(let valueInAttributes), .boolean(let valueInCondition)):
             switch op {
                 case .equals:
                     return valueInAttributes == valueInCondition
@@ -32,7 +32,7 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
             }
 
         // string, string
-        case let (.string(valueInAttributes), .string(valueInCondition)):
+        case (.string(let valueInAttributes), .string(let valueInCondition)):
             if String(op.rawValue).starts(with: "semver") {
                 // @TODO: handle semver comparisons here
 
@@ -99,7 +99,7 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
             }
 
         // date, string
-        case let (.date(valueInAttributes), .string(valueInCondition)):
+        case (.date(let valueInAttributes), .string(let valueInCondition)):
             switch op {
                 case .before:
                     let dateInAttributes = valueInAttributes
@@ -125,7 +125,7 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
             }
 
         // integer, integer
-        case let (.integer(valueInAttributes), .integer(valueInCondition)):
+        case (.integer(let valueInAttributes), .integer(let valueInCondition)):
             switch op {
                 case .equals:
                     return valueInAttributes == valueInCondition
@@ -144,7 +144,7 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
             }
 
         // double, double
-        case let (.double(valueInAttributes), .double(valueInCondition)):
+        case (.double(let valueInAttributes), .double(let valueInCondition)):
             switch op {
                 case .equals:
                     return valueInAttributes == valueInCondition
@@ -170,25 +170,25 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
 
 public func allConditionsAreMatched(condition: Condition, context: Context) -> Bool {
     switch condition {
-        case let .plain(condition):
+        case .plain(let condition):
             return conditionIsMatched(condition: condition, context: context)
 
-        case let .multiple(condition):
+        case .multiple(let condition):
             return condition.allSatisfy { condition in
                 allConditionsAreMatched(condition: condition, context: context)
             }
 
-        case let .and(condition):
+        case .and(let condition):
             return condition.and.allSatisfy { condition in
                 allConditionsAreMatched(condition: condition, context: context)
             }
 
-        case let .or(condition):
+        case .or(let condition):
             return condition.or.contains { condition in
                 allConditionsAreMatched(condition: condition, context: context)
             }
 
-        case let .not(condition):
+        case .not(let condition):
             return !condition.not.allSatisfy { condition in
                 allConditionsAreMatched(condition: condition, context: context)
             }

diff --git a/Sources/FeaturevisorSDK/Instance+Refresh.swift b/Sources/FeaturevisorSDK/Instance+Refresh.swift
@@ -21,7 +21,8 @@ extension FeaturevisorInstance {
 
         try? fetchDatafileContent(
             from: datafileUrl,
-            handleDatafileFetch: handleDatafileFetch) { [weak self] result in
+            handleDatafileFetch: handleDatafileFetch
+        ) { [weak self] result in
             guard let self else {
                 return
             }

diff --git a/Sources/FeaturevisorSDK/Instance+Segments.swift b/Sources/FeaturevisorSDK/Instance+Segments.swift
@@ -33,7 +33,7 @@ extension FeaturevisorInstance {
     ) -> Bool {
 
         switch groupSegments {
-            case let .plain(segmentKey):
+            case .plain(let segmentKey):
                 if segmentKey == "*" {
                     return true
                 }
@@ -44,7 +44,7 @@ extension FeaturevisorInstance {
 
                 return false
 
-            case let .multiple(groupSegments):
+            case .multiple(let groupSegments):
                 return groupSegments.allSatisfy { groupSegment in
                     allGroupSegmentsAreMatched(
                         groupSegments: groupSegment,
@@ -53,7 +53,7 @@ extension FeaturevisorInstance {
                     )
                 }
 
-            case let .and(andGroupSegment):
+            case .and(let andGroupSegment):
                 return andGroupSegment.and.allSatisfy { groupSegment in
                     allGroupSegmentsAreMatched(
                         groupSegments: groupSegment,
@@ -62,7 +62,7 @@ extension FeaturevisorInstance {
                     )
                 }
 
-            case let .or(orGroupSegment):
+            case .or(let orGroupSegment):
                 return orGroupSegment.or.contains { groupSegment in
                     allGroupSegmentsAreMatched(
                         groupSegments: groupSegment,
@@ -71,7 +71,7 @@ extension FeaturevisorInstance {
                     )
                 }
 
-            case let .not(notGroupSegment):
+            case .not(let notGroupSegment):
                 return !notGroupSegment.not.allSatisfy { groupSegment in
                     allGroupSegmentsAreMatched(
                         groupSegments: groupSegment,

diff --git a/Sources/FeaturevisorSDK/Instance.swift b/Sources/FeaturevisorSDK/Instance.swift
@@ -229,7 +229,8 @@ public class FeaturevisorInstance {
 
             try fetchDatafileContent(
                 from: datafileUrl,
-                handleDatafileFetch: handleDatafileFetch) { [weak self] result in
+                handleDatafileFetch: handleDatafileFetch
+            ) { [weak self] result in
                 switch result {
                     case .success(let datafileContent):
                         self?.datafileReader = DatafileReader(datafileContent: datafileContent)

diff --git a/Sources/FeaturevisorTypes/Extensions/KeyedDecodingContainer+Stringified.swift b/Sources/FeaturevisorTypes/Extensions/KeyedDecodingContainer+Stringified.swift
@@ -26,7 +26,8 @@ extension KeyedDecodingContainer {
 
     func decodeStringifiedIfPresent<T>(
         _ type: T.Type,
-        forKey key: KeyedDecodingContainer<K>.Key) throws -> T? where T: Decodable {
+        forKey key: KeyedDecodingContainer<K>.Key
+    ) throws -> T? where T: Decodable {
 
         guard self.contains(key) else {
             return nil

diff --git a/Tests/FeaturevisorSDKTests/InstanceTests.swift b/Tests/FeaturevisorSDKTests/InstanceTests.swift
@@ -689,7 +689,14 @@ class FeaturevisorInstanceTests: XCTestCase {
                     key: "myKey",
                     bucketBy: .single("userId"),
                     variations: [],
-                    required: [.withVariation(.init(key: "requiredKey", variation: "control"))],  // different variation
+                    required: [
+                        .withVariation(
+                            .init(
+                                key: "requiredKey",
+                                variation: "control"
+                            )
+                        )
+                    ],  // different variation
                     traffic: [
                         Traffic(
                             key: "1",
@@ -754,7 +761,14 @@ class FeaturevisorInstanceTests: XCTestCase {
                     key: "myKey",
                     bucketBy: .single("userId"),
                     variations: [],
-                    required: [.withVariation(.init(key: "requiredKey", variation: "treatment"))],  // desired variation
+                    required: [
+                        .withVariation(
+                            .init(
+                                key: "requiredKey",
+                                variation: "treatment"
+                            )
+                        )
+                    ],  // desired variation
                     traffic: [
                         Traffic(
                             key: "1",