Skip to content

Commit

Permalink
fix: rule percentage checks are now inclusive of end range (#63)
Browse files Browse the repository at this point in the history
  • Loading branch information
polok authored Feb 23, 2024
1 parent 6e6b411 commit 7be4657
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Sources/FeaturevisorSDK/Instance+Evaluation.swift
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,7 @@ extension FeaturevisorInstance {
}

// treated as enabled because of matched traffic
if bucketValue < matchedTraffic.percentage {
// @TODO: verify if range check should be inclusive or not
if bucketValue <= matchedTraffic.percentage {
evaluation = Evaluation(
featureKey: feature.key,
reason: .rule,
Expand Down

0 comments on commit 7be4657

Please sign in to comment.