Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make conditions work properly for every case #8

Merged
merged 10 commits into from
Oct 6, 2023
Merged

Make conditions work properly for every case #8

merged 10 commits into from
Oct 6, 2023

Conversation

uniumuniu
Copy link
Contributor

@uniumuniu uniumuniu commented Oct 4, 2023 •
edited
Loading

  • Refactor Conditions
  • Add unit tests for Conditions
  • Add dependencies for semver comparison and murmurhash

@uniumuniu uniumuniu requested a review from a team as a code owner October 4, 2023 14:23
fahad19
fahad19 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@fahad19 fahad19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@uniumuniu uniumuniu merged commit c5ba000 into main Oct 6, 2023
1 check passed
@uniumuniu uniumuniu deleted the handle-conditions branch October 6, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazabin mazabin mazabin approved these changes

@fahad19 fahad19 fahad19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uniumuniu @fahad19 @mazabin