Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Runner is failing in specific scenarios issue fixes #51

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Test Runner is failing in specific scenarios issue fixes #51

merged 2 commits into from
Sep 17, 2024

Conversation

Tan108
Copy link
Contributor

@Tan108 Tan108 commented Sep 16, 2024

This PR is to fix test runner failing issue in some specific scenarios below

  • When test assertion contains invalid Semver version.
  • In some ConditionValue and AttributeValue types like
    • when attributeValue is String and ConditionValue is Int
    • when attributeValue is Double and ConditionValue is String
    • when attributeValue is Int and ConditionValue is Array

Issue - #50

@Tan108 Tan108 requested a review from a team as a code owner September 16, 2024 07:24
@Tan108 Tan108 merged commit 9630444 into main Sep 17, 2024
1 check passed
@Tan108 Tan108 deleted the test_runner_failing_while_invalid_semver_version_issue_fixes branch September 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinha610 hsinha610 hsinha610 approved these changes

@fahad19 fahad19 fahad19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tan108 @fahad19 @hsinha610