Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues regarding serialization and error handling #13

Merged
merged 27 commits into from
Jan 16, 2024
Merged

Fix issues regarding serialization and error handling #13

merged 27 commits into from
Jan 16, 2024

Conversation

uniumuniu
Copy link
Contributor

@uniumuniu uniumuniu commented Nov 9, 2023 •
edited
Loading

  • fixed issues with deserialization
  • added unit tests

@uniumuniu uniumuniu requested a review from a team as a code owner November 9, 2023 11:14
@uniumuniu uniumuniu marked this pull request as draft November 16, 2023 10:22
@fahad19
Copy link
Member

fahad19 commented Jan 10, 2024

HI @uniumuniu! hope al is well.

do we expect to merge this PR anytime soon? :)

do you need any help by distributing the work?

@uniumuniu
Copy link
Contributor Author

HI @uniumuniu! hope al is well.

do we expect to merge this PR anytime soon? :)

do you need any help by distributing the work?

Hi :) Thanks, I hope everything's good on your side too!

This branch was dynamically changing when we were migrating flags, but I agree that's the time to finally merge it when it's stable. Let me look at missing unit tests that were the main concern here and clean up a bit. I'll start today, let's say merging till Friday would be the goal.

@uniumuniu uniumuniu changed the title Migrate instance Fix issues regarding serialization and error handling Jan 10, 2024
@fahad19
Copy link
Member

fahad19 commented Jan 10, 2024

awesome! please let me know if I can help you in any way, @uniumuniu!

feel free to create issues on GitHub if you don't have time to work on them, or just put them in the README.

trying to keep things steering forward incrementally without getting blocked.

@uniumuniu uniumuniu marked this pull request as ready for review January 14, 2024 21:17
@uniumuniu
Copy link
Contributor Author

After merge I'll be adding all known/found problems as issues. Next week I'll try to improve README.md content too.

@uniumuniu uniumuniu merged commit 9adb5af into main Jan 16, 2024
1 check passed
@uniumuniu uniumuniu deleted the migrate-instance branch January 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahad19 fahad19 fahad19 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uniumuniu @fahad19