Test Runner failed in case of invalid Semver version issue fixes (#49)

featurevisor · Aug 5, 2024 · d13cbeb · d13cbeb
1 parent ab978ba
commit d13cbeb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/main/kotlin/com/featurevisor/sdk/Conditions.kt b/src/main/kotlin/com/featurevisor/sdk/Conditions.kt
@@ -142,6 +142,10 @@ object Conditions {
     }
 
     private fun compareVersions(actual: String, condition: String): Int {
-        return SemVer.parse(actual).compareTo(SemVer.parse(condition))
+        return try {
+            SemVer.parse(actual).compareTo(SemVer.parse(condition))
+        } catch (e: Exception) {
+            0
+        }
     }
 }
diff --git a/src/main/kotlin/com/featurevisor/sdk/Instance+Evaluation.kt b/src/main/kotlin/com/featurevisor/sdk/Instance+Evaluation.kt
@@ -220,10 +220,9 @@ fun FeaturevisorInstance.evaluateVariation(featureKey: FeatureKey, context: Cont
         evaluation = Evaluation(
             featureKey = featureKey,
             reason = ERROR,
-            error(e)
         )
 
-        this.logger?.error("error", evaluation.toDictionary())
+        this.logger?.error(message = e.message.orEmpty(), details = evaluation.toDictionary())
 
         return evaluation
     }
@@ -433,10 +432,9 @@ fun FeaturevisorInstance.evaluateFlag(featureKey: FeatureKey, context: Context =
         evaluation = Evaluation(
             featureKey = featureKey,
             reason = ERROR,
-            error(e)
         )
 
-        this.logger?.error("error", evaluation.toDictionary())
+        this.logger?.error(message = e.message.orEmpty(), details = evaluation.toDictionary())
 
         return evaluation
     }

diff --git a/src/main/kotlin/com/featurevisor/testRunner/TestExecuter.kt b/src/main/kotlin/com/featurevisor/testRunner/TestExecuter.kt
@@ -41,7 +41,7 @@ fun startTest(option: TestProjectOption) {
                     try {
                         executionResult = executeTest(filePath, dataFile = datafile, option)
                     } catch (e: Exception) {
-                        printMessageInRedColor("Exception in $filePath --> ${e.message}")
+                        printMessageInRedColor("Exception while execution test --> ${e.message}")
                     }
 
                     if (executionResult == null) {