refactor: use range-based for loop to enhance readability (#68)

fcitx · Nov 6, 2024 · 8dffee6 · 8dffee6
1 parent cdd0efe
commit 8dffee6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/qt5/platforminputcontext/fcitxcandidatewindow.cpp b/qt5/platforminputcontext/fcitxcandidatewindow.cpp
@@ -452,11 +452,11 @@ void FcitxCandidateWindow::updateClientSideUI(
     doLayout(lowerLayout_);
     labelLayouts_.clear();
     candidateLayouts_.clear();
-    for (int i = 0; i < candidates.size(); i++) {
-        labelLayouts_.emplace_back(std::make_unique<MultilineText>(
-            theme_->font(), candidates[i].key()));
-        candidateLayouts_.emplace_back(std::make_unique<MultilineText>(
-            theme_->font(), candidates[i].value()));
+    for (const auto &candidate : candidates) {
+        labelLayouts_.emplace_back(
+            std::make_unique<MultilineText>(theme_->font(), candidate.key()));
+        candidateLayouts_.emplace_back(
+            std::make_unique<MultilineText>(theme_->font(), candidate.value()));
     }
     highlight_ = candidateIndex;
     hasPrev_ = hasPrev;

diff --git a/qt6/quickphrase-editor/model.cpp b/qt6/quickphrase-editor/model.cpp
@@ -225,8 +225,8 @@ QFutureWatcher<bool> *QuickPhraseModel::save(const QString &file) {
 }
 
 void QuickPhraseModel::saveDataToStream(QTextStream &dev) {
-    for (int i = 0; i < list_.size(); i++) {
-        dev << list_[i].first << "\t" << escapeValue(list_[i].second) << "\n";
+    for (const auto &item : list_) {
+        dev << item.first << "\t" << escapeValue(item.second) << "\n";
     }
 }
 
@@ -263,10 +263,10 @@ bool QuickPhraseModel::saveData(const QString &file,
             if (!tempFile.open(fd, QIODevice::WriteOnly)) {
                 return false;
             }
-            for (int i = 0; i < list.size(); i++) {
-                tempFile.write(list[i].first.toUtf8());
+            for (const auto &item : list) {
+                tempFile.write(item.first.toUtf8());
                 tempFile.write("\t");
-                tempFile.write(escapeValue(list[i].second).toUtf8());
+                tempFile.write(escapeValue(item.second).toUtf8());
                 tempFile.write("\n");
             }
             tempFile.close();