Normalize handler signature (and test fire) #105
Conversation
| } | ||
| , findTarget = function (event, eventElement) { | ||
| return fn.__beanDel ? fn.__beanDel.ft(event.target, element) : eventElement | ||
| } | ||
| , handler = condition | ||
| ? function (event) { | ||
| var target = findTarget(event, this) // deleated event | ||
| var target = findTarget(event, this) // delegated event |
|
Does |
|
this looks great. I couldn't get buster running either and started to get annoyed by it. It would be good to have this run thru the test suite before moving forward |
|
|
|
The whole buster-server setup is garbage and doesn't work, you'll have to run the static test page in the various browsers manually. See test.html, tho I haven't run it for ages and last time I checked Buster had problems with Node 1.0 (hence bustermove but that's for server-side). All it needs from Buster is the static assets for frontend testing. If you have no luck getting this going then let me know here and I'll see what I can do. If need be we'll have to switch out the test framework with something else that's kept up-to-date. |
|
@rvagg that doesn't work either.... mainly because i think buster changed. have a go at a fresh bean setup and you'll notice |
|
we probably need to switch to "buster-static" instead of "buster" |
| @@ -667,10 +667,13 @@ | |||
| // non-native event, either because of a namespace, arguments or a non DOM element | |||
| // iterate over all listeners and manually 'fire' | |||
| handlers = registry.get(element, type, null, false) | |||
| args = [false].concat(args) | |||
| event = new Event(null, element, nativeEvents[type]) | |||
There was a problem hiding this comment.
isNative use in the source makes me think this line should be be one of these:
event = new Event(null, element, !!element[eventSupport] && nativeEvents[type])event = new Event(null, element)
depending on whether native events fired manually due to args or namespace need .isNative
I made changes discussed in #102 and #80. I used a base
Eventobject and added.type. Doing it that way sets.isBeantotrueand some non-applicable properties toundefined.Buster does not work on my PC because it's XP probably. I could not run any Buster tests but I reworked the existing
fire()ones based on my changes. I made tests/fire-demo.html to inspect the args for now.