Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Make next_rails compatible with older ruby versions #50

Closed
arielj opened this issue Jun 22, 2022 · 3 comments · Fixed by #54
Closed

[REQUEST] Make next_rails compatible with older ruby versions #50

arielj opened this issue Jun 22, 2022 · 3 comments · Fixed by #54
Labels
enhancement New feature or request

Comments

@arielj
Copy link

arielj commented Jun 22, 2022

Branch/Commit:

Latest version I guess, it can't be installed

Problem:

next_rails currently requires ruby 2.3.0 or newer, which makes it incompatible with old rails projects using older ruby versions

we should find the reason for this limitation and maybe add some note or workaround, or maybe we can split the gem into different gems with different ruby restrictions if maybe the ruby restrictions is there because one feature and not for everything

I will abide by the code of conduct

@arielj arielj added the enhancement New feature or request label Jun 22, 2022
@etagwerker
Copy link
Member

@arielj there is some information over here:

@arielj
Copy link
Author

arielj commented Jul 5, 2022

I was doing some tests and it seems that the ruby version limitation can be removed, next_rails only depends on colorize now when added as a gem and colorize has no ruby version restriction. I tried removing the gem restriction and I was able to install it in Ruby 2.1.9 with no errors.

@arielj
Copy link
Author

arielj commented Jul 5, 2022

I was able to add support from Ruby 2.0.0 and on, since adding support to something like 1.9.3 is harder and requires rewritting stuff I'll leave that as another issue and leave the PR for this with support of Ruby 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants