Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Make next_rails compatible with Ruby older than 2.0 #57

Closed
arielj opened this issue Jul 5, 2022 · 1 comment
Closed

[REQUEST] Make next_rails compatible with Ruby older than 2.0 #57

arielj opened this issue Jul 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@arielj
Copy link

arielj commented Jul 5, 2022

Branch/Commit:

Main branch

Describe the feature:

It would be great to be able to use next_rails in projects using really old Ruby versions like 1.9.3, since this gem is used a lot for upgrades and there are still applications using this old Ruby version.

This is similar to #50, but while working on that I noticed that supporting older rubies has some breaking changes between < 2.0 and >= 2.0, so I'm adding this second issue to keep track of the older Ruby versions.

Problem:

Currently, next_rails requires Ruby 2.3, I was trying to add support for older ruby versions #54 but I found out that going older than Ruby 2 requires more things to be rewritten and code written differently depending on the Ruby version.

Resources:

Check this for reference: https://bugs.ruby-lang.org/issues/7664
You can also see the error with the keyword arguments syntax when I was testing this: https://github.com/fastruby/next_rails/runs/7201343800?check_suite_focus=true

I will abide by the code of conduct

@arielj arielj added the enhancement New feature or request label Jul 5, 2022
@arielj
Copy link
Author

arielj commented Oct 9, 2023

I did more research on this issue. Ruby 1.9.3 didn't support keyword arguments the same way Ruby 2 does, so keyword arguments passed to a method are actually one hash.

In order to support 1.9.3 we would have to move to using the old syntax to handle the arguments as a hash instead of keywords and I'm not sure if it's worth it. 1.9.3 is so old that it's probably more useful to first upgrade to Ruby 2.0 before trying to use next_rails anyway.

@arielj arielj closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant