-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AWS SSO + custom attributes to configure SNS platform app #7
base: master
Are you sure you want to change the base?
Support for AWS SSO + custom attributes to configure SNS platform app #7
Conversation
1bd8f6c
to
c2e3503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like these changes! I think my one question is if :access_key
, :secret_access_key
, and :region
should be optional / conflict with :client
🤷♂️ Thoughts?
Hey Josh, I read the code from config_item.rb and tried to modernize the available_options. I made the Also I'd love to know how you test individual Actions, I tried to update my smoke tests based on an official actions spec file. I think I'll get the hang of it with time. |
@return-main Hey! So sorry I missed this response 😱 Are you still using this and interested in getting this merged? 😇 I haven't personally used this in a while so I don't have a good testing environment setup for it but I'll get something setup if this is still something you think should be merged in! 😊 |
This commit adds the possibility to pass an AWS SNS client, which can be initialized with AWS SSO credentials. It also makes the code unit testable by providing a client with stub_responses (I'll make a separate PR for that). We also needed to configure the SNS platform app with various attributes like EventEndpointCreated, so I added a parameter for that. The full list of SNS platform application attributes can be found here: https://docs.aws.amazon.com/sns/latest/api/API_SetPlatformApplicationAttributes.html .
406b720
to
aa34e84
Compare
Hi @joshdholtz I put this in our production # Replace with
# gem 'fastlane-plugin-aws_sns'
# when https://github.com/fastlane-community/fastlane-plugin-aws_sns/pull/7 is merged
gem 'fastlane-plugin-aws_sns', git: 'https://github.com/return-main/fastlane-plugin-aws_sns.git', branch: 'feature/attributes_override' We are still interested in getting it merged, so I retested my code and squashed the commits for #7 and #8 |
This commit adds the possibility to pass an AWS SNS client, which can be initialized with AWS SSO credentials. It also makes the code unit testable by providing a client with
stub_responses
. I updated the Unit Tests in this PR.We also needed to configure the SNS platform app with various attributes like
EventEndpointCreated
, so I added a parameter for that. The full list of SNS platform application attributes can be found here.Our use-case :