-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission module: transition segment can now handle a payload decrease #580
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 100 100
Lines 6183 6186 +3
Branches 973 974 +1
=======================================
+ Hits 5683 5686 +3
Misses 334 334
Partials 166 166 ☔ View full report in Codecov by Sentry. |
@@ -433,10 +433,30 @@ Typically, it will be used as last segment to compute a reserve based on the Zer | |||
altitude: 0. | |||
mach: 0. | |||
|
|||
Mass loss without fuel consumption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mass loss without fuel consumption | |
Mass change without fuel consumption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in fcc948b
|
||
Using :code:`delta_mass` allows to simulate a fuel consumption equivalent to the mass loss. | ||
|
||
For cases where mass loss should be simulated without fuel consumption, it is possible to set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cases where mass loss should be simulated without fuel consumption, it is possible to set to | |
For cases where mass variation should be simulated without fuel consumption, it is possible to set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in fcc948b
|
||
segment: transition | ||
target: | ||
delta_mass: 100. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the example the delta_mass is postive --> mass gain instead of mass loss, it's not wrong but wouldn't it be more clear as an example if the dmass was negative?(as it was done at the test of the function)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied in fcc948b
607fe7e
to
fcc948b
Compare
This PR allows to simulate a mass loss that is not linked to fuel consumption.
Documentation preview: https://fast-oad.readthedocs.io/en/delta-payload-in-segment-transition/documentation/mission_module/mission_file/segments.html#mass-loss-without-fuel-consumption