Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission module: transition segment can now handle a payload decrease #580

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

christophe-david
Copy link
Contributor

@christophe-david christophe-david changed the title Transition segment can now handle a payload decrease Mission module: transition segment can now handle a payload decrease Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (0eb2816) to head (fcc948b).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         100      100           
  Lines        6183     6186    +3     
  Branches      973      974    +1     
=======================================
+ Hits         5683     5686    +3     
  Misses        334      334           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophe-david christophe-david marked this pull request as ready for review November 26, 2024 10:48
@@ -433,10 +433,30 @@ Typically, it will be used as last segment to compute a reserve based on the Zer
altitude: 0.
mach: 0.

Mass loss without fuel consumption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Mass loss without fuel consumption
Mass change without fuel consumption

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in fcc948b


Using :code:`delta_mass` allows to simulate a fuel consumption equivalent to the mass loss.

For cases where mass loss should be simulated without fuel consumption, it is possible to set to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For cases where mass loss should be simulated without fuel consumption, it is possible to set to
For cases where mass variation should be simulated without fuel consumption, it is possible to set to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in fcc948b


segment: transition
target:
delta_mass: 100.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the example the delta_mass is postive --> mass gain instead of mass loss, it's not wrong but wouldn't it be more clear as an example if the dmass was negative?(as it was done at the test of the function)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied in fcc948b

@christophe-david christophe-david force-pushed the delta-payload-in-segment-transition branch from 607fe7e to fcc948b Compare December 9, 2024 08:58
@dimitris-glenis dimitris-glenis merged commit a399b31 into master Dec 9, 2024
18 checks passed
@dimitris-glenis dimitris-glenis deleted the delta-payload-in-segment-transition branch December 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants