compiler: compile pod.js meta flag, redesign ES to only run with JS p…

…lug-in runs

The behavior since 6-Sept-2023 has been to run es compiler on every single pod
separately from if JS compiler was needed.  But this results in generating js
for pods like doc pods.

This changeset introduces two changes:

1. add pod.js flag if we generate es code into the pod (and APIs to check it via CPod)

2. changes es code generation to use same check as js code generation

This change now requires that ES depends are omitted if dependency has no js code

src/compiler/fan/assembler/Assembler.fan

@@ -48,6 +48,7 @@ class Assembler : CompilerSupport, FConst
   {
     meta := pod.meta
     meta["pod.fcode"] = (!types.isEmpty).toStr
+    meta["pod.js"]    = (compiler.cjs != null || compiler.isSys).toStr
     return meta
   }
 
@@ -169,4 +170,5 @@ class Assembler : CompilerSupport, FConst
 //////////////////////////////////////////////////////////////////////////
 
   FPod? fpod
-}
+}
+

src/compiler/fan/ast/PodDef.fan

@@ -65,11 +65,12 @@ class PodDef : Node, CPod
 // Fields
 //////////////////////////////////////////////////////////////////////////
 
-  override CNamespace ns            // compiler's namespace
-  override const Str name           // simple pod name
-  Str:Str meta := Str:Str[:]        // pod meta-data props
-  Str:Obj index := Str:Obj[:]       // pod index props (vals are Str or Str[])
-  CompilationUnit[] units           // Tokenize
-  [Str:TypeDef]? typeDefs           // ScanForUsingsAndTypes
+  override CNamespace ns                // compiler's namespace
+  override const Str name               // simple pod name
+  override Str:Str meta := Str:Str[:]   // pod meta-data props
+  Str:Obj index := Str:Obj[:]           // pod index props (vals are Str or Str[])
+  CompilationUnit[] units               // Tokenize
+  [Str:TypeDef]? typeDefs               // ScanForUsingsAndTypes
+
+}
 
-}

src/compiler/fan/fcode/FPod.fan

@@ -293,24 +293,25 @@ final class FPod : CPod, FConst
 // Fields
 //////////////////////////////////////////////////////////////////////////
 
-  override CNamespace ns    // compiler's namespace
-  override Str name         // pod's unique name
-  override Version version  // pod version
+  override CNamespace ns     // compiler's namespace
+  override Str name          // pod's unique name
+  override Version version   // pod version
   override CDepend[] depends // pod dependencies
-  Str:Str meta              // pod meta
-  Str:Obj index             // pod index
-  Zip? zip                  // zipped storage
-  FType[]? ftypes           // pod's declared types
-  FTable names              // identifier names: foo
-  FTable typeRefs           // types refs:   [pod,type,sig]
-  FTable fieldRefs          // fields refs:  [parent,name,type]
-  FTable methodRefs         // methods refs: [parent,name,ret,params]
-  FTable ints               // Int literals
-  FTable floats             // Float literals
-  FTable decimals           // Decimal literals
-  FTable strs               // Str literals
-  FTable durations          // Duration literals
-  FTable uris               // Uri literals
-  [Str:FType]? ftypesByName // if loaded
-
-}
+  override Str:Str meta      // pod meta
+  Str:Obj index              // pod index
+  Zip? zip                   // zipped storage
+  FType[]? ftypes            // pod's declared types
+  FTable names               // identifier names: foo
+  FTable typeRefs            // types refs:   [pod,type,sig]
+  FTable fieldRefs           // fields refs:  [parent,name,type]
+  FTable methodRefs          // methods refs: [parent,name,ret,params]
+  FTable ints                // Int literals
+  FTable floats              // Float literals
+  FTable decimals            // Decimal literals
+  FTable strs                // Str literals
+  FTable durations           // Duration literals
+  FTable uris                // Uri literals
+  [Str:FType]? ftypesByName  // if loaded
+
+}
+

src/compiler/fan/namespace/CPod.fan

@@ -43,6 +43,16 @@ mixin CPod
   **
   abstract File file()
 
+  **
+  ** Pod meta data
+  **
+  abstract Str:Str meta()
+
+  **
+  ** Return if this pod has client side JavaScript
+  **
+  Bool hasJs() { meta["pod.js"] == "true" || name == "sys" }
+
   **
   ** Lookup a type by its simple name.  If the type doesn't
   ** exist and checked is true then throw UnknownTypeErr
@@ -87,4 +97,5 @@ mixin CPod
     return name
   }
 
-}
+}
+

src/compiler/fan/namespace/ReflectPod.fan

@@ -28,6 +28,8 @@ class ReflectPod : CPod
 
   override once File file() { Env.cur.findPodFile(name) }
 
+  override Str:Str meta() { pod.meta }
+
   override CType[] types()
   {
     if (!loadedAllTypes)
@@ -60,4 +62,5 @@ class ReflectPod : CPod
   private Str:ReflectType typeMap := Str:ReflectType[:]
   private Bool loadedAllTypes := false
 
-}
+}
+

src/compiler/fan/steps/CompileJs.fan

@@ -27,15 +27,13 @@ class CompileJs  : CompilerStep
     if (needCompileJs)
     {
       compile("compilerJs::CompileJsPlugin")
-      genTsDecl
     }
 
-    if (pod.name != "sys")
+    if (needCompileEs)
     {
-      // we need to generate new javascript for all pods even if no js types
-      compile("compilerEs::CompileEsPlugin")
+      if (pod.name != "sys") compile("compilerEs::CompileEsPlugin")
+      genTsDecl
     }
-
   }
 
   private Void compile(Str qname)
@@ -71,6 +69,11 @@ class CompileJs  : CompilerStep
     }
   }
 
+  Bool needCompileEs()
+  {
+    needCompileJs
+  }
+
   Bool needCompileJs()
   {
     // in JS mode we force JS compilation
@@ -89,4 +92,5 @@ class CompileJs  : CompilerStep
     return this.hasJs
   }
 
-}
+}
+

src/compilerJava/fan/JavaPod.fan

@@ -42,6 +42,8 @@ class JavaPod : CPod
 
   override File file() { throw UnsupportedErr() }
 
+  override const Str:Str meta := [:]
+
   const Str packageName
 
   override const Version version := Version.defVal
@@ -68,4 +70,5 @@ class JavaPod : CPod
   ** Is this the fanx.interop package?
   const Bool isInterop
 
-}
+}
+

src/doc/docIntro/doc/ChangeLog.fandoc

@@ -22,6 +22,8 @@
 - Fix Color HSL implementation to match browser behavoir
 - Add MimeType.isText
 - Add util::LockFile
+- Redesign ES compiler to not generate code for every pod
+- Include TypeScript decl file in pods with JS code
 
 *Build 1.0.79 (17 Jul 2023)*
 - New yaml API

src/doc/docLang/doc/Pods.fandoc

@@ -62,6 +62,7 @@ The following are the standardized keys automatically defined by compiler:
   - 'pod.isScript': was the pod compiled in script mode
   - 'pod.docSrc': should documentation include source code, see [BuildPod]`build::BuildPod.docSrc`
   - 'pod.docApi': should pod be included in documentation, see [BuildPod]`build::BuildPod.docApi`
+  - 'pod.js': does pod include client side JavaScript code (true or false)
   - 'pod.native.java': does pod use native Java code (true or false)
   - 'pod.native.dotnet': does pod use native .NET code (true or false)
   - 'pod.native.js': does pod use native JavaScript code (true or false)