Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#595): Fixed navbar content overflow for small devices #598

Conversation

ahmedhalac
Copy link
Contributor

@ahmedhalac ahmedhalac commented Nov 15, 2024

Fixed overflow for devices in width from 770px to 820px
Also fixed alignment for "Map" and "About" since they weren't aligned properly. There was minor difference.

TESTING RESULTS:

Screenshot 2024-11-15 at 10 28 53 PM Screenshot 2024-11-15 at 10 29 33 PM

Closes #595

height: 100%;
display: flex;
align-items: center;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property makes the background look like this when Map is clicked:
Screenshot from 2024-11-16 15-44-41

@@ -67,6 +68,10 @@ const StyledHeader = styled.header`
font-weight: bold;
font-size: 1rem;

@media (min-width: 767px) and (max-width: 820px) {
Copy link
Collaborator

@wbazant wbazant Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've correctly identified the reason for the layout to go funky, it's that min-width:110px that you're unsetting! I'm not sure if the solution is the best we can do, it happens to work in French, but at the cost of making the click area for the Map link quite small - see here with added background colors:
Screenshot from 2024-11-16 15-50-53

Is there a way to do a flexible layout for these links?

Also, there'll be a third link there - the Activity tab - see #537 . If you're working on it, you could add the third link, let it link to /changes which will not render anything until we finish that feature, and then we'll have a good layout even with three links.

@wbazant
Copy link
Collaborator

wbazant commented Jan 13, 2025

Closing in favour of #661. Thanks @ahmedhalac for figuring out what caused the overflow, it was helpful for solving the issue!

@wbazant wbazant closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout of top ribbon for small desktop heights can overflow
2 participants