Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests/falco): drop debug printlns. #55

Merged
merged 2 commits into from
May 9, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 9, 2024

/hold
in case i need to also fix some bugs.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

/unhold

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

/hold wait for ci

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

/unhold
ci fails because Falco master CI was not able to push updated images (with the fix) because it got stuck at testing-packages of course.
Works locally against a Falco built from master:

./build/falco.test -falco-binary /home/federico/Work/falco/build/userspace/falco/falco -test.run TestFalco_Miscs_HotReload -test.v 
=== RUN   TestFalco_Miscs_HotReload
{"deadline":180000000000,"level":"info","msg":"running falco with runner","time":"2024-05-09T14:44:32+02:00"}
{"cmd":"/home/federico/Work/falco/build/userspace/falco/falco -c /home/federico/Work/testing/hot_reload_enabled.yaml -r single_rule.yaml -M 5 -o engine.kind=nodriver -o log_level=debug -o log_stderr=true -o log_syslog=false -o stdout_output.enabled=true","level":"debug","msg":"executing command","time":"2024-05-09T14:44:32+02:00"}
--- PASS: TestFalco_Miscs_HotReload (7.66s)
PASS

@poiana
Copy link

poiana commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label May 9, 2024
@poiana poiana merged commit 50aee19 into falcosecurity:main May 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants