Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(pkg,tests): added a test for Falco hot reload. #54

Merged
merged 1 commit into from
May 9, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 9, 2024

No description provided.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

Should not pass against latest dev Falco because of: falcosecurity/falco#3188

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2024

Confirm it is failing 😺 https://github.com/falcosecurity/testing/actions/runs/9014123246?pr=54

EDIT: of course i tested it locally against my Falco with the fix and it works.

@incertum
Copy link
Contributor

incertum commented May 9, 2024

Amazing thanks for also adding this test 😅 it's gonna help in the future!

@poiana
Copy link

poiana commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label May 9, 2024
@poiana poiana merged commit dca902f into falcosecurity:main May 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants