fix(tests): use legacy rules files for legacy tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Legacy tests are designed to test Falco features, not the ruleset. Most of these tests already use ad-hoc rules files, not those provided by the tested Falco package. This commit also aligns the same behavior for legacy tests requiring the default rulesets. This is particularly relevant after we split `falco_rules.yaml` in multiple files, which are not shipped anymore by default. Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
fix/legacy-tests-rules-files
branch
from
225bc1a
to
4af105a
Compare
|
I'm fixing some failing tests. Hold on please 🙏 |
leogr
changed the title
leogr
force-pushed
the
fix/legacy-tests-rules-files
branch
7 times, most recently
from
b2034e1
to
1cce593
Compare
Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
fix/legacy-tests-rules-files
branch
from
1cce593
to
31b4840
Compare
|
Found the issue falcosecurity/falco#2784 |
|
/hold cancel |
leogr
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
added a commit
to falcosecurity/falco
that referenced
this pull request
Sep 6, 2023
See falcosecurity/testing#24 Signed-off-by: Leonardo Grasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy tests are designed to test Falco features, not the ruleset. Most of these tests already use ad-hoc rules files, not those provided by the tested Falco package. This commit also aligns the same behavior for legacy tests requiring the default rulesets. This is particularly relevant after we split
falco_rules.yamlin multiple files, which are not shipped anymore by default.