Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: add support to bump ia32->64 syscalls map too. #13

Merged
merged 4 commits into from
Oct 11, 2023
Merged

new: add support to bump ia32->64 syscalls map too. #13

merged 4 commits into from
Oct 11, 2023

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Jul 12, 2023

@poiana poiana requested review from Andreagit97 and leogr July 12, 2023 07:58
@FedeDP FedeDP mentioned this pull request Jul 12, 2023
Merged
4 tasks
@poiana poiana added size/L and removed size/M labels Oct 5, 2023
@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 5, 2023

build syscalls-bumper Expected — Waiting for status to be reported

Not triggered? 🤔

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 5, 2023

/close

@poiana poiana closed this Oct 5, 2023
@poiana
Copy link

poiana commented Oct 5, 2023

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 5, 2023

/reopen

@poiana poiana reopened this Oct 5, 2023
@poiana
Copy link

poiana commented Oct 5, 2023

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added size/M and removed size/L labels Oct 11, 2023
@FedeDP
Copy link
Collaborator Author

FedeDP commented Oct 11, 2023

/unhold

Andreagit97
Andreagit97 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 11, 2023
@poiana
Copy link

poiana commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e374b1a into main Oct 11, 2023
3 checks passed
@poiana poiana deleted the new/ia32_map_support branch October 11, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@leogr leogr Awaiting requested review from leogr

Assignees

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedeDP @poiana @Andreagit97