-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(proc/scan): scan all existing threads #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/fix-k8smeta-proc-scan
branch
from
November 6, 2024 14:19
455daa6
to
93f374c
Compare
alacuku
force-pushed
the
kcl/fix-k8smeta-proc-scan
branch
from
November 6, 2024 15:57
93f374c
to
cf94973
Compare
Rules files suggestions |
By scanning only /proc we missed the threads of a given process. It scans all threads under a given process in /proc/pid/task. Signed-off-by: Aldo Lacuku <[email protected]>
alacuku
force-pushed
the
kcl/fix-k8smeta-proc-scan
branch
from
November 6, 2024 16:35
cf94973
to
46ddda0
Compare
Rules files suggestions |
LucaGuerra
reviewed
Nov 7, 2024
LucaGuerra
approved these changes
Nov 7, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: cfbe98e41ece0ccf81199752065947c45f32ff76
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By scanning only /proc we missed the threads of a given process. It scans all threads under a given process in /proc/pid/task.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
By scanning only /proc we missed the threads of a given process.
It scans all threads under a given process in /proc/pid/task.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: