Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/okta): introduce optional UseAsync field in okta plugin #507

Merged

Conversation

SKosier
Copy link
Contributor

@SKosier SKosier commented Jun 13, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link

Rules files suggestions

rules

Comparing 86521838a4e10e77d762d76ef8588fa1ce08cf55 with latest tag okta-0.10.0

Minor changes:

  • Version dependency to plugin okta has been incremented

@poiana poiana added size/S and removed size/XS labels Jun 13, 2024
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch the version number to 0.11.0

Otherwise, SGMT.

plugins/okta/pkg/okta/okta.go Outdated Show resolved Hide resolved
@SKosier SKosier force-pushed the skosier/plugins/okta/introduce-use-async branch from a581691 to 8652183 Compare June 13, 2024 12:17
@poiana poiana added size/XS and removed size/S labels Jun 13, 2024
@SKosier SKosier requested a review from leogr June 13, 2024 12:26
Copy link

Rules files suggestions

rules

Comparing 86521838a4e10e77d762d76ef8588fa1ce08cf55 with latest tag okta-0.10.0

Minor changes:

  • Version dependency to plugin okta has been incremented

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, SKosier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: 9384b7299857ad2fd4a40aedca98b36dd55dfb08

@poiana poiana merged commit ea17a79 into falcosecurity:main Jun 17, 2024
21 checks passed
@Issif
Copy link
Member

Issif commented Jun 17, 2024

@SKosier could create another PR to update the changelog and the plugin version. Moreover, the parameter has to be used in the Init() func, see

extract.SetAsync(k.Config.UseAsync)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants