fix(ci): build temporary plugins required for release-time validation #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
poiana
added
kind/bug
Rules files suggestions |
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
Rules files suggestions |
Signed-off-by: Jason Dellaluce <[email protected]>
Rules files suggestionsaws_cloudtrail_rules.yamlComparing `` with latest tag No changes detected |
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
fix/validation-ci
branch
from
25c21ec
to
4951da6
Compare
Signed-off-by: Jason Dellaluce <[email protected]>
Rules files suggestionsaws_cloudtrail_rules.yamlComparing No changes detected |
Rules files suggestionsaws_cloudtrail_rules.yamlComparing No changes detected |
Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
fix/validation-ci
branch
from
08135df
to
38a8b81
Compare
Rules files suggestionsaws_cloudtrail_rules.yamlComparing No changes detected |
jasondellaluce
changed the title
leogr
approved these changes
Aug 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: a2d5228b10b0c93563fd59059fe9aa3275116e62
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Our release workflow might fail when validating the locally-built plugins due to potentially-required plugins being missing. This happens because at release time we only build the released plugin, whereas validation might require more than one locally-built plugin.
For example, when releasing
k8sauditwe build only that plugin in release mode, however when validating with local packages we need Falco to load bothk8sauditandjson(because the k8s audit ruleset requiresjsontoo), and so we need to build a dev package forjsonon the fly.Which issue(s) this PR fixes:
Special notes for your reviewer: