-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): include jiffies.h to prevent warning about missing prototype #2143
Conversation
…type Signed-off-by: Holger Hoffstätte <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 81ea78b0853ae74498ea65b6662c32234bb6a0a3
|
/milestone next-driver |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2143 +/- ##
=========================================
Coverage ? 74.69%
=========================================
Files ? 254
Lines ? 33502
Branches ? 5725
=========================================
Hits ? 25025
Misses ? 8472
Partials ? 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, hhoffstaette The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The prototype for
nsec_to_clock_t
is in<linux/jiffies.h>
, which is not included byppm_cputime.c
.jiffies.h
includestime.h
so we can just switch the import.What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
no
Which issue(s) this PR fixes:
Fixes #2142
Does this PR introduce a user-facing change?: