Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): include jiffies.h to prevent warning about missing prototype #2143

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

hhoffstaette
Copy link
Contributor

@hhoffstaette hhoffstaette commented Nov 3, 2024

The prototype for nsec_to_clock_t is in <linux/jiffies.h>, which is not included by ppm_cputime.c. jiffies.h includes time.h so we can just switch the import.

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area driver-kmod

Does this PR require a change in the driver versions?

no

Which issue(s) this PR fixes:

Fixes #2142

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 4, 2024

LGTM label has been added.

Git tree hash: 81ea78b0853ae74498ea65b6662c32234bb6a0a3

@poiana poiana added the approved label Nov 4, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Nov 4, 2024

/milestone next-driver
Thank you very much for the fix!

@poiana poiana added this to the next-driver milestone Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Perf diff from master - unit tests

     3.05%     -0.82%  [.] sinsp::fetch_next_event
     3.47%     -0.60%  [.] gzfile_read
     1.71%     +0.58%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     2.84%     +0.55%  [.] sinsp_thread_manager::get_thread_ref
     0.84%     -0.54%  [.] thread_group_info::get_first_thread
     1.67%     +0.52%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     1.66%     -0.46%  [.] libsinsp::state::stl_container_table_adapter<std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t>::stl_container_table_adapter
     1.21%     -0.45%  [.] sinsp_parser::event_cleanup
     8.99%     +0.43%  [.] sinsp_parser::reset
     4.04%     +0.40%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0247         -0.0246           151           147           151           147
BM_sinsp_split_median                                          -0.0285         -0.0285           151           147           151           147
BM_sinsp_split_stddev                                          +1.9786         +1.9727             0             1             0             1
BM_sinsp_split_cv                                              +2.0539         +2.0476             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0353         -0.0352            57            55            57            55
BM_sinsp_concatenate_paths_relative_path_median                -0.0373         -0.0372            57            55            57            55
BM_sinsp_concatenate_paths_relative_path_stddev                +1.1277         +1.1305             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +1.2056         +1.2082             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0530         -0.0529            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0520         -0.0519            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5381         -0.5361             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5123         -0.5102             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0055         +0.0056            56            57            56            57
BM_sinsp_concatenate_paths_absolute_path_median                +0.0062         +0.0062            56            57            56            57
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.1444         +1.1436             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.1326         +1.1316             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0120         -0.0119           405           400           405           400
BM_sinsp_split_container_image_median                          -0.0150         -0.0149           406           400           406           400
BM_sinsp_split_container_image_stddev                          +0.5340         +0.5363             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.5526         +0.5548             0             0             0             0

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5f32757). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2143   +/-   ##
=========================================
  Coverage          ?   74.69%           
=========================================
  Files             ?      254           
  Lines             ?    33502           
  Branches          ?     5725           
=========================================
  Hits              ?    25025           
  Misses            ?     8472           
  Partials          ?        5           
Flag Coverage Δ
libsinsp 74.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, hhoffstaette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d7daa63 into falcosecurity:master Nov 4, 2024
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in 0.18.1: no previous prototype for 'nsec_to_clock_t' [-Wmissing-prototypes]
4 participants