-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(libsinsp): add len() filter transformer #2131
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2131 +/- ##
==========================================
+ Coverage 74.46% 74.60% +0.13%
==========================================
Files 254 254
Lines 33340 33458 +118
Branches 5724 5720 -4
==========================================
+ Hits 24827 24961 +134
+ Misses 8508 8470 -38
- Partials 5 27 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/milestone 0.19.0 |
20f42b7
to
87b1321
Compare
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]> Signed-off-by: Luca Guerra <[email protected]>
…), t(list[i]))... Signed-off-by: Luca Guerra <[email protected]>
… cases Signed-off-by: Luca Guerra <[email protected]>
87b1321
to
5263f40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just last few concerns/questions
Signed-off-by: Luca Guerra <[email protected]>
Thanks! Addressed comments |
LGTM label has been added. Git tree hash: a224ada55b3058be76302af4ac6ad6a1508ff483
|
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This introduces a new
len()
transformer which acts like you'd expect:len(some_list)
evaluates to the number of elements in the listlen(some_string)
evaluates to the length of the string (excluding null terminator of course)len(some_buffer)
evaluates to the number of bytes in the bufferThis is also a handy way to check if lists are empty, since we couldn't do it before, which was apparent after a discussion with @leogr and @jasondellaluce .
Which issue(s) this PR fixes:
Fixes #2127
Special notes for your reviewer:
Does this PR introduce a user-facing change?: