wip: chore(libsinsp): remove unused container manager method

[leogr]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

Does this PR require a change in the driver versions?
No

What this PR does / why we need it:

Cleanup.
Groundwork for falcosecurity/falco#3279

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Perf diff from master - unit tests

     5.40%     -1.30%  [.] next
     3.93%     +1.19%  [.] sinsp_parser::process_event
     9.21%     +0.95%  [.] sinsp_parser::reset
     2.04%     -0.74%  [.] sinsp::fetch_next_event
     5.24%     -0.73%  [.] sinsp_evt::get_type
     0.73%     +0.52%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.95%     -0.50%  [.] sinsp_evt::get_direction
     3.03%     -0.47%  [.] sinsp_thread_manager::get_thread_ref
     1.18%     -0.47%  [.] sinsp_filter_check::parse_field_name
     1.50%     -0.46%  [.] 0x00000000000ea3b0

Heap diff from master - unit tests

peak heap memory consumption: 608B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 560B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0345         +0.0344           149           154           149           154
BM_sinsp_split_median                                          +0.0307         +0.0308           149           153           149           153
BM_sinsp_split_stddev                                          -0.0593         -0.0592             2             2             2             2
BM_sinsp_split_cv                                              -0.0906         -0.0905             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0681         +0.0681            58            62            58            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0766         +0.0766            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8884         -0.8883             2             0             2             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8955         -0.8954             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0898         +0.0897            23            25            23            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0690         +0.0690            23            25            23            25
BM_sinsp_concatenate_paths_empty_path_stddev                  +13.1278        +13.1091             0             1             0             1
BM_sinsp_concatenate_paths_empty_path_cv                      +11.9643        +11.9472             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0775         +0.0775            59            63            59            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.0627         +0.0627            60            63            60            63
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8946         -0.8946             3             0             3             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.9021         -0.9021             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0015         -0.0015           389           389           389           389
BM_sinsp_split_container_image_median                          -0.0017         -0.0018           389           389           389           389
BM_sinsp_split_container_image_stddev                          -0.4709         -0.4707             4             2             4             2
BM_sinsp_split_container_image_cv                              -0.4701         -0.4699             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (3216d09) to head (04fce8b).
Report is 29 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2117      +/-   ##
==========================================
+ Coverage   74.45%   74.60%   +0.14%     
==========================================
  Files         253      254       +1     
  Lines       33052    33256     +204     
  Branches     5655     5682      +27     
==========================================
+ Hits        24610    24811     +201     
- Misses       8411     8429      +18     
+ Partials       31       16      -15     

Flag	Coverage Δ
libsinsp	74.60% <ø> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leogr]

I'd like to address falcosecurity/falco#3279 for Falco 0.40, so tentatively for

/milestone 0.19.0

[leogr]

/hold

[leogr]

Abandoned in favor of #2141
/close

[poiana]

@leogr: Closed this PR.

In response to this:

Abandoned in favor of #2141
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.