sync 0.17.x branch #1974
Merged
sync 0.17.x branch #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly keep a reference on m_sinsp_stats_v2 where needed, instead of fetching it every time. Moreover, improve perf in `sinsp_utils::ts_to_string`: cache `gmt2local` result instead of fetching it every time as it is an heavy operation. Signed-off-by: Federico Di Pierro <[email protected]>
… return empty value, to be skipped, when requirements are not met. For now, this means that metrics that require `m_sinsp_stats_v2` will be automatically skipped when it is disabled. Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
…nd ipnet checks Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]> Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
poiana
added
release-note-none
kind/bug
|
Please double check driver/API_VERSION file. See versioning. /hold |
|
/milestone 0.17.3 |
|
Added also #1979 to the 0.17.3 milestone. |
|
Moved also #1946 to 0.17.3 milestone to fix
|
FedeDP
reviewed
Jul 31, 2024
Build zlib using CMake on Windows instead of nmake. The nmakefile passes "-base:0x5A4C0000" to the linker, which is too small on Arm64 and not really needed or wanted on any platform these days. madler/zlib#325 Signed-off-by: Gerald Combs <[email protected]>
Set CMAKE_POLICY_DEFAULT_CMP0091, CMAKE_MSVC_RUNTIME_LIBRARY, and CMAKE_BUILD_TYPE when we configure zlib, similar to our other dependencies. Signed-off-by: Gerald Combs <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib. Signed-off-by: Gerald Combs <[email protected]>
LucaGuerra
force-pushed
the
update/sync-release-0.17.3
branch
from
370da2c
to
aeaa769
Compare
|
Thanks @FedeDP , added everything |
Include cri.hpp in container.cpp in order to avoid ``` /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libsinsp.so: undefined reference to `libsinsp::cri::cri_interface<libsinsp::cri::cri_api_v1>::get_cri_runtime_type() const' collect2: error: ld returned 1 exit status ``` when building with shared libs on Linux. Signed-off-by: Gerald Combs <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
Signed-off-by: Roberto Scolaro <[email protected]>
|
LGTM label has been added. Git tree hash: 58713b9e3d6b81e8cfba568ef8bd21623cdce595
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libsinsp
Does this PR require a change in the driver versions?
/version driver-API-version-patch
What this PR does / why we need it:
Sync 0.17.x release branch with the following changes:
Also, increment driver API version because we are patching it (@FedeDP please double check that this is correct).API version does not need to be incrementedWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: