Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update plugins_hostinfo config file comment. #3449

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore(docs): update plugins_hostinfo config file comment. #3449

merged 3 commits into from
Jan 16, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 15, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Andreagit97 and Kaizhe January 15, 2025 16:24
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 15, 2025

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Jan 15, 2025
@poiana poiana added the size/XS label Jan 15, 2025
sgaist
sgaist requested changes Jan 16, 2025
View reviewed changes
falco.yaml Outdated
# dropping the `hostPath` volume requirement for them.
# that DO NOT generate raw events from the libscap event table
# or for plugins that DO NOT parse raw events generated by drivers,
# effectively dropping the `hostPath` volume requirement for them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a link to the "hostPath volume requirement".

Because, as a user, reading this, I would search in this file for more information and since there's no other mention of hostPath, would have to start digging through the doc (or maybe even the code) for what that might be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, will put a link to the charts section!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@leogr leogr requested a review from sgaist January 16, 2025 08:22
leogr
leogr previously approved these changes Jan 16, 2025
View reviewed changes
@poiana poiana added the lgtm label Jan 16, 2025
sgaist
sgaist reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better !

One last question: AFAICS the pod template does not make the proc-fs hostPath optional so it is a bit confusing. Did I miss something ?

leogr
leogr reviewed Jan 16, 2025
View reviewed changes
falco.yaml Outdated Show resolved Hide resolved
@FedeDP @leogr
update: update falco.yaml
c87ba77 
Co-authored-by: Leonardo Grasso <[email protected]>
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025 •
edited
Loading

Did I miss something ?

@sgaist you did not miss anything! The next chart version will make it optional with a flag :) cc @alacuku

@sgaist
Copy link
Contributor

sgaist commented Jan 16, 2025

Did I miss something ?

@sgaist you did not miss anything! The next chart version will make it optional with a flag :) cc @alacuku

So my helm-fu is still good :-)

In that case, should this change be merged after the one on the chart ?

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 16, 2025

In that case, should this change be merged after the one on the chart ?

Unfortunately, the chart gets updated very very near the release, and it can even get released a couple of days after the release :(
Also, this change was already merged, we are only fixing the comment right now!

@sgaist
Copy link
Contributor

sgaist commented Jan 16, 2025

In that case, should this change be merged after the one on the chart ?

Unfortunately, the chart gets updated very very near the release, and it can even get released a couple of days after the release :( Also, this change was already merged, we are only fixing the comment right now!

Understood
At least we have this ticket in case people are wondering for the mismatch.

@poiana poiana merged commit 7339363 into master Jan 16, 2025
33 checks passed
@poiana poiana deleted the chore/update_hostinfo_comment branch January 16, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@sgaist sgaist sgaist approved these changes

@Andreagit97 Andreagit97 Awaiting requested review from Andreagit97

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@sgaist sgaist

@leogr leogr

Labels
approved dco-signoff: yes kind/cleanup lgtm release-note-none size/XS
Projects
Falco Roadmap
Status: Done
Milestone
0.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @sgaist @leogr