Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize main project (Closing Milestone v14.0.2) #17

Closed
wants to merge 5 commits into from
Closed

Synchronize main project (Closing Milestone v14.0.2) #17

wants to merge 5 commits into from

Conversation

yjf2002ghty
Copy link

@yjf2002ghty yjf2002ghty commented May 9, 2024

This pull request merges recent changes like fairy-stockfish/Fairy-Stockfish#780 and fairy-stockfish/Fairy-Stockfish#792 . If there are any changes, you can apply the changes based on this pull request which can save time.

Note that I removed the "Publish to NPM" step in the CI as I'm not the publisher. Adding back it is needed before or after merging.

      - name: Publish to NPM
        if: startsWith(github.ref, 'refs/tags/')
        working-directory: src/emscripten/public
        run: |
          npm config set //registry.npmjs.org/:_authToken ${NPM_TOKEN}
          npm publish
        env:
          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

I've tested it in the CI and it passed.
image

@ianfab
Copy link
Member

ianfab commented Jun 1, 2024

Thanks. However, for the dependent projects like wasm and NNUE data generator I prefer to directly merge from the upstream project to keep the history clean, otherwise this might create future merge conflicts.

With respect to the CI, my assumption is that there would be no need to remove the publish step, since this is only triggered by tag creation, so nobody without the required write access can do it by accident.

@ianfab ianfab closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants