Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cfour-anyside, Symphony, Teeko #731

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add Cfour-anyside, Symphony, Teeko #731

merged 5 commits into from
Oct 24, 2023

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented Sep 29, 2023

No description provided.

@RainRat
add Teeko, Symphony, Roll4
e411c86
@RainRat
delete the part that says intentionally not ORed. I was thinking an e…
db70ab4 
…asy way to initialize first time around. but no, it doesn't work like that
@RainRat
going to call it cfour-anyside instead of roll4, so it's less confusa…
97df83f 
…ble with roll-ing-to-four. but I could go with either or a third option.
ianfab
ianfab reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@ianfab ianfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just added two CR comments.

I only realized thanks to your PR that actually dropOnTop might be a very good candidate to merge into the enclosingDrop. Since the former was implemented first I think I missed the similarity when introducing enclosing drops. Not necessarily a request to implement this in your PR, just a side note.

src/position.cpp Outdated Show resolved Hide resolved
src/position.h Outdated Show resolved Hide resolved
@RainRat
Copy link
Contributor Author

RainRat commented Oct 11, 2023

Thanks, I just added two CR comments.

I only realized thanks to your PR that actually dropOnTop might be a very good candidate to merge into the enclosingDrop. Since the former was implemented first I think I missed the similarity when introducing enclosing drops. Not necessarily a request to implement this in your PR, just a side note.

I was actually thinking of suggesting that next.

@RainRat
Copy link
Contributor Author

RainRat commented Oct 22, 2023 •
edited
Loading

  1. Implemented optimization suggestions
  2. Added code for how "enclosingDrop = top" could work. (optional)
  3. Manually resolved conflict with 3 previous variants.ini additions.

@ianfab ianfab merged commit 3f40ada into fairy-stockfish:master Oct 24, 2023
12 of 15 checks passed
@ianfab
Copy link
Member

ianfab commented Oct 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianfab ianfab ianfab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RainRat @ianfab