Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed few tests #705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils/mappingHelpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function extractComments (data) {
*/
let comments = [];

for (const path of ['ds:8', 'ds:9']) {
for (const path of ['ds:8', 'ds:9', 'ds:10']) {
const authorPath = [path, 0, 0, 1, 0];
const versionPath = [path, 0, 0, 10];
const datePath = [path, 0, 0, 5, 0];
Expand Down
6 changes: 3 additions & 3 deletions test/lib.permissions.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('Permissions method', () => {
}));

it('should return an array of permissions and descriptions for different response format', () =>
gplay.permissions({ appId: 'air.tv.ingames.cubematch.free' })
gplay.permissions({ appId: 'www.whimmusic.info' })
.then((results) => {
assert(results.length);
results.forEach((perm) => {
Expand All @@ -30,14 +30,14 @@ describe('Permissions method', () => {
}));

it('should return skip descriptions if short option is passed for different response format', () =>
gplay.permissions({ appId: 'air.tv.ingames.cubematch.free', short: true })
gplay.permissions({ appId: 'com.sgn.pandapop.gp', short: true })
.then((results) => {
assert(results.length);
results.map(assert.isString);
}));

it('should return even if app have no common permissions', () =>
gplay.permissions({ appId: 'com.skybornegames.battlepop' })
gplay.permissions({ appId: 'www.whimmusic.info' })
.then((results) => {
assert(results.length);
results.forEach((perm) => {
Expand Down
2 changes: 1 addition & 1 deletion test/lib.similar.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ describe('Similar method', () => {
});

it('should fetch games from different developers', () => {
return gplay.similar({ appId: 'com.instagram.android' })
return gplay.similar({ appId: 'www.whimmusic.info' })
.then((apps) => assert.isTrue(apps.some(app => app.developer !== apps[0].developer)));
});
});
Loading