Serialise as Boolean if operator is defined

facultyai · Jun 3, 2019 · 3a605a9 · 3a605a9
1 parent 2d4050c
commit 3a605a9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/faculty/clients/experiment.py b/faculty/clients/experiment.py
@@ -365,7 +365,9 @@ def _deserialize(self, value, attr, data, **kwargs):
         return value
 
     def _serialize(self, value, attr, obj, **kwargs):
-        if obj.by in {SingleFilterBy.PROJECT_ID, SingleFilterBy.RUN_ID}:
+        if obj.operator == SingleFilterOperator.DEFINED:
+            field = fields.Boolean()
+        elif obj.by in {SingleFilterBy.PROJECT_ID, SingleFilterBy.RUN_ID}:
             field = fields.UUID()
         elif obj.by == SingleFilterBy.EXPERIMENT_ID:
             field = fields.Integer()

diff --git a/tests/clients/test_experiment.py b/tests/clients/test_experiment.py
@@ -384,6 +384,16 @@ def test_experiment_run_data_schema_multiple():
     "value": DELETED_AT_STRING_PYTHON,
 }
 
+DELETED_FILTER = SingleFilter(
+    SingleFilterBy.DELETED_AT, None, SingleFilterOperator.DEFINED, True
+)
+DELETED_FILTER_BODY = {
+    "by": "deletedAt",
+    "key": None,
+    "operator": "defined",
+    "value": True,
+}
+
 TAG_FILTER = SingleFilter(
     SingleFilterBy.TAG, "tag_key", SingleFilterOperator.EQUAL_TO, "tag_value"
 )
@@ -488,6 +498,7 @@ def test_experiment_run_data_schema_multiple():
         [EXPERIMENT_ID_FILTER, EXPERIMENT_ID_FILTER_BODY],
         [RUN_ID_FILTER, RUN_ID_FILTER_BODY],
         [DELETED_AT_FILTER, DELETED_AT_FILTER_BODY],
+        [DELETED_FILTER, DELETED_FILTER_BODY],
         [TAG_FILTER, TAG_FILTER_BODY],
         [PARAM_NUM_FILTER, PARAM_NUM_FILTER_BODY],
         [PARAM_TEXT_FILTER, PARAM_TEXT_FILTER_BODY],